Make Grok3 streaming work with OpenAI Compatible #2449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dosubot
bot
added
the
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| const isGrokXAI = this._isGrokXAI(this.options.openAiBaseUrl) | ||
|
|
||
| const requestOptions: OpenAI.Chat.Completions.ChatCompletionCreateParamsStreaming = { |
Contributor
There was a problem hiding this comment.
Consider extracting the logic for constructing streaming options into a helper function to reduce duplication.
mrubens
approved these changes
Apr 10, 2025
ouob-tw
added a commit
to ouob-tw/BigFont-Roo-Code
that referenced
this pull request
May 6, 2025
fix: update ChatRowContent(user msg in chat windows) background and font size for better styling Add o1-pro to api.ts (RooCodeInc#2433) Add the o1-pro model to the openai section. Sourced model info from: https://platform.openai.com/docs/models/o1-pro Update contributors list (RooCodeInc#2411) docs: update contributors list [skip ci] Co-authored-by: mrubens <[email protected]> Add custom instructions for de (RooCodeInc#2383) v3.11.11 (RooCodeInc#2435) API fixes (RooCodeInc#2438) Changeset version bump (RooCodeInc#2436) * changeset version bump * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Rubens <[email protected]> More sane evals default concurrency + staggered startup (RooCodeInc#2441) Fix gh fork command (RooCodeInc#2442) Add a script to copy eval run results to Turso (RooCodeInc#2452) Fall back on aggressive line number stripping in diffs (RooCodeInc#2453) * Add option for aggressive line number stripping * Fall back on aggressive line number stripping in diffs Make Grok3 streaming work with OpenAI Compatible (RooCodeInc#2449) Update contributors list (RooCodeInc#2434) docs: update contributors list [skip ci] Co-authored-by: mrubens <[email protected]> v3.11.12 (RooCodeInc#2454) Changeset version bump (RooCodeInc#2455) * changeset version bump * Updating CHANGELOG.md format * Update CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: R00-B0T <[email protected]> Co-authored-by: Matt Rubens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allow streaming to be used when using Open AI Compatible provider with Grok3 API directly.
Implementation
If x.ai in base_url remove unsupported stream_options.
Screenshots
How to Test
Configure Grok3 API in the Open AI Compatible provider and enable streaming support, observe the 400 error "unsupported option: stream_options".
After fix streaming works with Grok3 as expected.
References
https://docs.x.ai/docs/guides/streaming-response#streaming-response
Important
Enable Grok3 streaming in
OpenAiHandlerby excludingstream_optionsfor x.ai base URLs, with tests added.openai.ts,OpenAiHandlernow excludesstream_optionswhenbase_urlis for x.ai, enabling Grok3 streaming._isGrokXAI()to check if the base URL is for x.ai.openai.test.ts, adds tests for Grok xAI configuration and verifiesstream_optionsexclusion during streaming.This description was created by
for dc3f06c. It will automatically update as commits are pushed.